Use AddWrappedAspNetCoreSession to better fit standard naming #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a method (WrapAsnnetCoreSession) that wraps the ASP.NET Core session for use with System.Web.SessionState APIs, but this name is not in line with the standard service collection extensions of (`Add...`). This change obsoletes the old one and applies the normal convention.
twsouthwick
force-pushed
the
tasou/add-wrapped
branch
from
89bc5d2 to
d746faf
Compare
Clounea
approved these changes
Oct 17, 2023
Tratcher
reviewed
Oct 24, 2023
...re.SystemWebAdapters.CoreServices/SessionState/Wrapped/WrappedAspNetCoreSessionExtensions.cs
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
Oct 24, 2023
twsouthwick
force-pushed
the
tasou/add-wrapped
branch
from
37ed041 to
107b641
Compare
NSHenry
added a commit
to NSHenry/AspNetCore.Docs
that referenced
this pull request
Feb 21, 2025
WrapAspNetCoreSession was changed to AddWrappedAspNetCoreSession in version 1.3.0 of SystemWebAdapters Pull Request: dotnet/systemweb-adapters#424 1.3.0 Version Notes: https://github.com/dotnet/systemweb-adapters/releases/tag/v1.3.0
This was referenced Feb 21, 2025
Rick-Anderson
pushed a commit
to dotnet/AspNetCore.Docs
that referenced
this pull request
Feb 25, 2025
WrapAspNetCoreSession was changed to AddWrappedAspNetCoreSession in version 1.3.0 of SystemWebAdapters Pull Request: dotnet/systemweb-adapters#424 1.3.0 Version Notes: https://github.com/dotnet/systemweb-adapters/releases/tag/v1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a method (WrapAsnnetCoreSession) that wraps the ASP.NET Core session for use with System.Web.SessionState APIs, but this name is not in line with the standard service collection extensions of (
Add...). This change obsoletes the old one and applies the normal convention.